Closed
Conversation
added 2 commits
July 20, 2011 09:12
Contributor
Author
|
See bug 635099 for the mockup. |
Contributor
There was a problem hiding this comment.
Is this needed because self.solution can be out of date?
Contributor
Author
There was a problem hiding this comment.
I added it because there are times you care that a solution exists, but not necessarily what it is: exists() is faster than pulling the whole thing (unless you've already got the solution by select_related).
Contributor
|
looks hot. tests pass. r+ |
Contributor
|
new test looks good! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Display a lot more info about questions in the AAQ search results.